netdev - Re: [PATCH] smsc911x: Change clock warning message to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2014 15:09:36 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Fabio Estevam <fabio.estevam@...escale.com>,
	steve.glendinning@...well.net
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] smsc911x: Change clock warning message to debug level

Hello.

On 03/19/2014 05:22 PM, Fabio Estevam wrote:

> Since passing the clock is not mandatory, change the warning message to debug,
> so that we avoid getting the following clock failure message on every boot:

> smsc911x: Driver version 2008-10-21
> smsc911x smsc911x (unregistered net_device): couldn't get clock -2
> libphy: smsc911x-mdio: probed

> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>   drivers/net/ethernet/smsc/smsc911x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
> index 6382b7c..95e2b9a 100644
> --- a/drivers/net/ethernet/smsc/smsc911x.c
> +++ b/drivers/net/ethernet/smsc/smsc911x.c
> @@ -439,7 +439,7 @@ static int smsc911x_request_resources(struct platform_device *pdev)
>   	/* Request clock */
>   	pdata->clk = clk_get(&pdev->dev, NULL);
>   	if (IS_ERR(pdata->clk))
> -		netdev_warn(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
> +		netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));

    Looks like using netdev_dbg() is premature at  this point (see that 
"unregistered net_device"), so I'd replace netdev_*(ndev, ...) with 
dev_*(&pdev->dev, ...)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html