lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 24 Mar 2014 00:13:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	wangyufen@...wei.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: tcp_ipv6 policy route issue

From: Wangyufen <wangyufen@...wei.com>
Date: Mon, 24 Mar 2014 09:36:01 +0800

> From: Wang Yufen <wangyufen@...wei.com>
> 
> The issue raises when adding policy route,specify a particular
> NIC as oif. The policy route did not take effect.The reason is
> that fl6.oif is not set and route map failed. From the 
> tcp_v6_send_response function,if the binding address is linklocal,
> fl6.oif is set,but not for global address.
> 
> Signed-off-by: Wang Yufen <wangyufen@...wei.com>

You didn't follow all of my feedback.  I said that there must
be a space after punctuation characters, such as "," in your
commit message.

You lack a space after all such characters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ