netdev - Re: [PATCH] tg3: Do not include vlan acceleration features in vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140326.155614.1586642968372896396.davem@davemloft.net>
Date:	Wed, 26 Mar 2014 15:56:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org, nsujir@...adcom.com, mchan@...adcom.com
Subject: Re: [PATCH] tg3: Do not include vlan acceleration features in
 vlan_features

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Mon, 24 Mar 2014 17:52:12 -0400

> Including hardware acceleration features in vlan_features breaks
> stacked vlans (Q-in-Q) by marking the bottom vlan interface as
> capable of acceleration.  This causes one of the tags to be lost
> and the packets are sent with a sing vlan header.
> 
> CC: Nithin Nayak Sujir <nsujir@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

Applied and queued up for -stable, thanks.

This is at least the second time I've seen a fix exactly like this
one, it certainly therefore deserves a tree-wide audit if anyone has
time for that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html