netdev - Re: [PATCH net-next v5 2/3] ipv6: reuse rt6_need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 17:40:35 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Wangyufen <wangyufen@...wei.com>, davem@...emloft.net,
	netdev@...r.kernel.org
CC:	kuznet@....inr.ac.ru
Subject: Re: [PATCH net-next v5 2/3] ipv6: reuse rt6_need_strict

Hello.

On 28-03-2014 13:20, Wangyufen wrote:

> From: Wang Yufen <wangyufen@...wei.com>

> Move the whole rt6_need_strict as static inline into ip6_route.h,
> so that it can be reused

> Signed-off-by: Wang Yufen <wangyufen@...wei.com>
> ---
>   include/net/ip6_route.h | 5 +++++
>   net/ipv6/route.c        | 6 ------
>   2 files changed, 5 insertions(+), 6 deletions(-)

> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
> index 00e3f12..33e8694 100644
> --- a/include/net/ip6_route.h
> +++ b/include/net/ip6_route.h
> @@ -51,6 +51,11 @@ static inline unsigned int rt6_flags2srcprefs(int flags)
>   	return (flags >> 3) & 7;
>   }
>
> +static inline bool rt6_need_strict(const struct in6_addr *daddr)
> +{
> +	return ipv6_addr_type(daddr) &
> +		IPV6_ADDR_MULTICAST | IPV6_ADDR_LINKLOCAL | IPV6_ADDR_LOOPBACK);

    I don't think removing parens was correct here: & should have more 
priority than |.

> +}
>
>   void ip6_route_input(struct sk_buff *skb);
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index b93ae6a..5015c50 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -374,12 +374,6 @@ static bool rt6_check_expired(const struct rt6_info *rt)
>   	return false;
>   }
>
> -static bool rt6_need_strict(const struct in6_addr *daddr)
> -{
> -	return ipv6_addr_type(daddr) &
> -		(IPV6_ADDR_MULTICAST | IPV6_ADDR_LINKLOCAL | IPV6_ADDR_LOOPBACK);
> -}
> -
>   /* Multipath route selection:
>    *   Hash based function using packet header and flowlabel.
>    * Adapted from fib_info_hashfn()

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html