netdev - Re: [RFC PATCH] vlan: Try to adjust lower device mtu when configuring 802.1AD vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Apr 2014 14:21:21 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH] vlan: Try to adjust lower device mtu when
 configuring 802.1AD vlans

On Tue, Apr 01, 2014 at 05:17:34PM -0400, Vlad Yasevich wrote:
> 802.1AD vlans supposed to encapsulate 802.1Q vlans.  To
> do this, we need an extra 4 bytes of header which are typically
> not accounted for by lower devices.  Some devices can not
> support frames longer then 1522 bytes at all.  Such devices
> can not really support 802.1AD, even in software, without
> the vlan reducing its mtu value.
> 
> This patch propses to increate the lower devices MTU to 1504
> in case of 802.1AD configuration, and if device doesn't
> support it, fail the creation of the vlan.  The user has an
> option to configure older-style Q-in-Q vlans and manually
> lower the mtu to support such encapsulation.

I think you should do the opposite. The lower layer device may be used
for other things than the VLAN, so it doesn't seem right to change it's
MTU. Instead I'd propose to set the MTU of the 802.1ad VLAN device to
the lower device'e MTU - 4 unless a MTU has been specified by the user.

BTW, I couldn't find anything related to MTU handling in the 802.1ad
standard, however I only have an old copy and might have looked in the
wrong place. Do you have any information how this is supposed to be
handled?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html