netdev - Re: [PATCH] vxlan: using AF_PACKET socket to send multicast packet cause WARNING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Apr 2014 12:48:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vxlan: using AF_PACKET socket to send multicast packet
 cause WARNING

From: lucien xin <lucien.xin@...il.com>
Date: Thu, 3 Apr 2014 13:28:33 +0800

> On Wed, Apr 2, 2014 at 10:51 PM, Stephen Hemminger
> <stephen@...workplumber.org> wrote:
>> That breaks local socket accounting for tunneled packets.
> It do break, I think it should break, becaue vlxan send UDP packets,
> it should be bound to UDP socket.

The issue is that we use sockets in two different contexts here:

1) For memory accounting, which is why we should hold onto the
   original socket.

2) For IP transmit state, which is why we need to reference the
   vxlan layer's ipv4/ipv6 socket.

Also, we've never marked the vxlan socket as being charged to
the SKB, there may be unwanted side effects of this.

Furthmore this will hurt performance, it will add two new
atomic operations per packet send over VXLAN devices.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html