netdev - [PATCH] Documentation: document the gianfar tx vlan offload issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri,  4 Apr 2014 11:04:45 +0800
From:	roy.qing.li@...il.com
To:	netdev@...r.kernel.org
Cc:	claudiu.manoil@...escale.com, Yanjun.Zhu@...driver.com
Subject: [PATCH] Documentation: document the gianfar tx vlan offload issue

From: Li RongQing <roy.qing.li@...il.com>

The commit b852b72087[gianfar: fix bug caused by 87c288c6e9] and e2c53be223
[gianfar: fix default tx vlan offload feature flag] disabled tx vlan offload
from dev->feature, since enabling vlan tag insertion leads to unusable
connections on some configurations.

But this feature is in dev->hw_feature still, and a user can enable it by
"ethtool", so document the tx vlan offload issue.

Signed-off-by: Li RongQing <roy.qing.li@...il.com>
Signed-off-by: Zhu Yanjun <Yanjun.Zhu@...driver.com>
Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
---
 Documentation/networking/gianfar.txt |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/networking/gianfar.txt b/Documentation/networking/gianfar.txt
index ad474ea..2d3dbe6 100644
--- a/Documentation/networking/gianfar.txt
+++ b/Documentation/networking/gianfar.txt
@@ -51,6 +51,18 @@ configuring VLANs.  The gianfar driver supports hardware insertion and
 extraction of VLAN headers, but not filtering.  Filtering will be
 done by the kernel.
 
+But if tx vlan tag hardware insertion is enabled, and a vlan-device is
+created, the physical device which vlan device is on will be unable to
+work, like:
+
+	$ethtool -K eth0 tx-vlan-stag-hw-insert on
+	$ifconfig eth0 192.168.1.13/24 up
+
+	$vconfig add eth0 4091
+	$ifconfig eth0.4091 10.1.1.13/24 up
+eth0.4091 can work, but eth0 can not work, since eth0 sends the insane
+packets out.
+
 MULTICASTING
 
 The gianfar driver supports using the group hash table on the
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html