lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 10 Apr 2014 19:09:30 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, greearb@...delatech.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] macvlan: Move broadcasts into a work queue

On Fri, 2014-04-11 at 09:59 +0800, Herbert Xu wrote:
> On Thu, Apr 10, 2014 at 09:40:23PM -0400, David Miller wrote:
> > From: Herbert Xu <herbert@...dor.apana.org.au>
> > Date: Wed, 9 Apr 2014 01:23:49 +0800
> > 
> > > On Tue, Apr 08, 2014 at 09:48:40AM -0700, Ben Greear wrote:
> > >> 
> > >> At least for ARPs, maybe we could inspect the packet and only
> > >> deliver to interfaces configured with the MAC that is being
> > >> ARPed for (or ones that are in promisc)?
> > > 
> > > Yes this would definitely be a great optimisation.
> > 
> > Yes and you can use the direct rather than the workqueue path.
> 
> This would be a worthy optimisation for bridge.c too.  In fact,
> I wonder if it would be possible to share some of the broadcast/
> multicast logic between macvlan and bridge.

But many ARP messages are broadcasted, particularly when you restart
an hypervisor with thousand of macvlan. This is the moment we have
this horrible quadratic behavior in macvlan.

I do not understand the idea...

ARP filter would require to inspect the queried IPv4 address, and
macvlan do not currently have a list of IPv4 addresses per port.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists