netdev - Re: [PATCH] net IPv6: Remove unnecessary argument of ndisc_send_ns and ndisc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 14:13:18 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	Balakumaran Kannan <kumaran.4353@...il.com>, davem@...emloft.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net,
	netdev@...r.kernel.org, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] net IPv6: Remove unnecessary argument of ndisc_send_ns
 and ndisc_send_na

Balakumaran Kannan wrote:
> The 'neigh' argument of 'ndisc_send_ns' and 'ndisc_send_na' are not used in
> these functions. So this could be removed.
> 
> And a minor change of 'optlen' assignment in those functions. the compound
> addition and assignment operator is not needed as 'optlen' value is always
> zero.

Do not mix changes.

Well, it is for future extension so that we can prepend another option
easier.  Do you see any penalty here?


> 
> Signed-off-by: Balakumaran Kannan <kumaran.4353@...il.com>
> ---
> I am not sure whether 'neigh' argument is intentional or planned for any
> future use. If you find this is unnecessary, this patch could be considered.
> 
> And ndisc_send_na is used as a function pointer in ipv6_stub. This may affect anybody
> using this structure. But with default configuration built, I didn't get any error or
> warning. Kindly consider this scenario also. 

drivers/net/usb/cdc_mbim.c uses it at least.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html