netdev - Re: [Patch net 1/3] net: move LOOPBACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 12:13:13 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Julian Anastasov <ja@....bg>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net 1/3] net: move LOOPBACK_IFINDEX to include/net/flow.h

On Tue, Apr 15, 2014 at 12:06 PM, David Miller <davem@...emloft.net> wrote:
>
> Cong, first of all, I'd like you to combine patches #1 and #2.
>

OK, whatever you prefer...I have no strong opinion here.

> Also, Julian made it clear that several other changes needed happen
> besides the single fib_validate_source() call site you are modifying
> in patch #3.
>
> He also said, for example, that the flow4_iif assignment in
> __fib_validate_source() needs adjusting as well.
>
> He furthermore said that other assignments of zero to flow4_iif
> in netfilter and elsewhere must be adjusted as well.

I believe I did in patch #2, or I still miss anything?

>
> Please also provide a proper 0/N patch posting next time explaining
> exactly what the series does and why it is necessary.

OK, will do, I thought per-patch description is enough.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html