netdev - Re: skb_try_coalesce bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2014 12:56:20 -0400
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Erik Hugne <erik.hugne@...csson.com>, <netdev@...r.kernel.org>
Subject: Re: skb_try_coalesce bug?

On 04/22/2014 05:37 PM, Eric Dumazet wrote:
> On Tue, 2014-04-22 at 14:29 -0700, Eric Dumazet wrote:
> 
>> Then if you do that, you also need to change head->data_len !
> 
> Untested patch would be :
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c
> index c5190ab75290..85077dd7c63e 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -2349,6 +2349,7 @@ int tipc_link_frag_rcv(struct sk_buff **head, struct sk_buff **tail,
>  			(*tail)->next = frag;
>  		*tail = frag;
>  		(*head)->truesize += frag->truesize;
> +		(*head)->data_len += frag->len;

Just to confirm, does this mean that head's own (linear) data is not
included in data_len? 

///jon

>  	}
>  	if (fragid == LAST_FRAGMENT) {
>  		*fbuf = *head;
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html