netdev - Re: [patch net-next] vlan: Don't allow vlan devices to change network namespaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 08:59:51 +0800
From:	chenweilong <chenweilong@...wei.com>
To:	<nicolas.dichtel@...nd.com>, Eric Dumazet <eric.dumazet@...il.com>
CC:	<kaber@...sh.net>, <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [patch net-next] vlan: Don't allow vlan devices to change network
 namespaces.

On 2014/4/23 15:23, Nicolas Dichtel wrote:
> Le 23/04/2014 04:40, chenweilong a écrit :
>> On 2014/4/22 22:26, Eric Dumazet wrote:
>>> On Tue, 2014-04-22 at 20:43 +0800, Chen Weilong wrote:
>>>> From: Weilong Chen <chenweilong@...wei.com>
>>>>
>>>> Like bonding, vlan as netdevice doesn't cross netns boundaries.
>>>>
>>>> Vlan port and vlan itself live in same netns.
>>>
>>> Please explain why you believe it should be like that.
>>>
>>> bonding and vlan have quite different purpose, so your changelog is
>>> quite obscure.
>>>
>>> We had a discussion like this one with macvlan, and prior patch was
>>> rejected.
>>>
>>>
>>>
>>>
>> This idea comes from the different result of two changing namespace orders.
>> Test on eth1 and its vlan eth1.5, move them form default ns to a new ns called net0.
>> 1.move eth1 first,and then eth1.5;
>> 2.move eth1.5 first, and then eth1;
>> As a network manager, I will be happy they both work, I don't care about the orders.
>> But, 1) doesn't work, if eth1 was moved to other ns, all related vlans were unregisted.
>> you need to create a new eth1.5 in net0.
>> And, 2) is not safe, if someone forgets to move eth1, eth1.5 will not work, making
>> things complex.
> We have to fix this case, because it is a valid use case to have eth1.5 in net0
> and eth1 in another ns.
> 
eth1.5 can receive and send packets in net0, the problem is you can't add a new eth1.5
in old ns, report 'error: File exists'.

>>
>> So what's the better order ?
>> I prefer 1), when a vlan dev is setup, it has a namespace, and belongs to it,
>> When somebody moves it, it should say 'hey boy, don't move me,I like here :0'
>>
>> Thanks,
>> Weilong
> -- 
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html