netdev - Re: [PATCH net v2] Altera TSE: Fix DMA secriptor length initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2014 09:05:21 +0200
From:	Tobias Klauser <tobias.klauser@...il.com>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	nios2-dev <nios2-dev@...ts.rocketboards.org>
Subject: Re: [PATCH net v2] Altera TSE: Fix DMA secriptor length initialization

On 29 April 2014 00:37, Vince Bridgers <vbridgers2013@...il.com> wrote:
> On Mon, Apr 28, 2014 at 4:23 PM, Tobias Klauser
> <tobias.klauser@...il.com> wrote:
>> sgdma_descrip is a function name as well as the name of a struct. In
>> sgdma_initialize(), we should initialize the descriptor length field
>> with the actual length of a descriptor not with the size of the
>> function. In order to prevent such things from happening in the future,
>> rename the function to sgdma_setup_descrip().
>>
>> Found by sparse which yields the following warning:
>>
>> drivers/net/ethernet/altera/altera_sgdma.c:74:30: warning: expression using sizeof on a function
>>
>> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
>> ---
>> v2: patchd rebase against current net tree
>>
>
> Thanks for the patch Tobias. Was the misspelling in the subject line
> an oversight (secriptor -> descriptor) ?

Yes, this was an oversight, sorry. Thanks for pointing out.

Dave, shall I send an updated patch with the correct subject line or can
you fix it up before applying?

Thanks
Tobias
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html