netdev - Re: [PATCH net v2] Altera TSE: Fix DMA secriptor length initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2014 16:14:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tobias.klauser@...il.com
Cc:	vbridgers2013@...il.com, netdev@...r.kernel.org,
	nios2-dev@...ts.rocketboards.org
Subject: Re: [PATCH net v2] Altera TSE: Fix DMA secriptor length
 initialization

From: Tobias Klauser <tobias.klauser@...il.com>
Date: Mon, 28 Apr 2014 23:23:01 +0200

> sgdma_descrip is a function name as well as the name of a struct. In
> sgdma_initialize(), we should initialize the descriptor length field
> with the actual length of a descriptor not with the size of the
> function. In order to prevent such things from happening in the future,
> rename the function to sgdma_setup_descrip().
> 
> Found by sparse which yields the following warning:
> 
> drivers/net/ethernet/altera/altera_sgdma.c:74:30: warning: expression using sizeof on a function
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html