netdev - Re: [PATCH] qlcnic: clarify hwmon Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2014 15:51:27 +0000
From:	Harish Patil <harish.patil@...gic.com>
To:	Arnd Bergmann <arnd@...db.de>, netdev <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>
Subject: Re: [PATCH] qlcnic: clarify hwmon Kconfig dependency



>commit 1f0f467b670e "qlcnic: Add hwmon interface to export board
>temperature" introduced a randconfig build error in the case
>when the hwmon framework is built as a module and the qlcnic
>driver itself is built-in:
>
>drivers/built-in.o: In function `qlcnic_register_hwmon_dev':
>drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1301: undefined
>reference to `hwmon_device_register_with_groups'
>drivers/built-in.o: In function `qlcnic_unregister_hwmon_dev':
>drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1309: undefined
>reference to `hwmon_device_unregister'
>
>This changes the Kconfig logic to enforce that the qlcnic hwmon
>support can only be enabled if it is possible to successfully
>build it.
>
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>Cc: Harish Patil <harish.patil@...gic.com>
>
>diff --git a/drivers/net/ethernet/qlogic/Kconfig
>b/drivers/net/ethernet/qlogic/Kconfig
>index 0482adb..9493824 100644
>--- a/drivers/net/ethernet/qlogic/Kconfig
>+++ b/drivers/net/ethernet/qlogic/Kconfig
>@@ -69,6 +69,7 @@ config QLCNIC_VXLAN
> config QLCNIC_HWMON
>       bool "QLOGIC QLCNIC 82XX and 83XX family HWMON support"
>       depends on QLCNIC && HWMON
>+      depends on QLCNIC=m || HWMON=y
>       default y
>       ---help---
>         This configuration parameter can be used to read the
>
>
Can we make it into an one line expression as done in few other cases:

diff --git a/drivers/net/ethernet/qlogic/Kconfig
b/drivers/net/ethernet/qlogic/K
index b818432..d49cba1 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -68,7 +68,7 @@ config QLCNIC_VXLAN

 config QLCNIC_HWMON
        bool "QLOGIC QLCNIC 82XX and 83XX family HWMON support"
-       depends on QLCNIC && HWMON
+       depends on QLCNIC && HWMON && !(QLCNIC=y && HWMON=m)
        default y
        ---help---
          This configuration parameter can be used to read the




________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.