lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 May 2014 09:30:58 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Alexey Charkov' <alchark@...il.com>, Roger Luethi <rl@...lgate.ch>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Jan Moskyto Matejka" <mq@...e.cz> Subject: RE: [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit From: Alexey Charkov [mailto:alchark@...il.com] ... > This patch removes the cast altogether, and instead stores an actual > pointer to u8 in match->data. All instances of 'revision' are also > unified to u8 instead of an assortment of different integer types, > in line with the definition of 'revision' in struct pci_dev. ... > +static u8 vt8500_revision = 0x84; > static struct of_device_id rhine_of_tbl[] = { > - { .compatible = "via,vt8500-rhine", .data = (void *)0x84 }, > + { .compatible = "via,vt8500-rhine", .data = &vt8500_revision }, > { } /* terminate list */ Actually the above looks strange. Why does the vt8500 have a revision number of 0x84 ? Surely it should be 0x85, or even 0x8500 (or decimal 85000). David
Powered by blists - more mailing lists