netdev - Re: [PATCH 02/26] can: c_can: Fix startup logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 May 2014 14:37:58 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Yegor Yefremov <yegorslists@...glemail.com>
CC:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	kernel@...gutronix.de, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 02/26] can: c_can: Fix startup logic

On 04/29/2014 09:29 AM, Yegor Yefremov wrote:
> On Fri, Apr 25, 2014 at 12:00 AM, Marc Kleine-Budde <mkl@...gutronix.de> wrote:
>> From: Thomas Gleixner <tglx@...utronix.de>
>>
>> c_can_start() enables interrupts way too early. The first enabling
>> happens when setting the control mode in c_can_chip_config() and then
>> again at the end of the function.
>>
>> But that happens before napi_enable() and that means that an interrupt
>> which comes in will disable interrupts again and call napi_schedule,
>> which ignores the request and the later napi_enable() is not making
>> thinks work either. So the interface is up with all device interrupts
>> disabled.
>>
>> Move the device interrupt after napi_enable() and add it to the other
>> callsites of c_can_start() in c_can_set_mode() and c_can_power_up()
>>
>> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>> Tested-by: Alexander Stein <alexander.stein@...tec-electronic.com>
>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> 
> Tested-by: Yegor Yefremov <yegorslists@...glemail.com>

Thanks, as this branch is already merged by David, it's too late to add
your Tested-by.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html