[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 05 May 2014 15:40:04 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: ezequiel.garcia@...e-electrons.com
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
w@....eu, thomas.petazzoni@...e-electrons.com,
jason@...edaemon.net, gregory.clement@...e-electrons.com,
sebastian.hesselbarth@...il.com, andrew@...n.ch,
tawfik@...vell.com, alior@...vell.com
Subject: Re: [PATCH 1/7] net: mv643xx_eth: Simplify
mv643xx_eth_adjust_link()
From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Date: Sat, 3 May 2014 15:26:56 -0300
> Currently, mv643xx_eth_adjust_link() is only used to call mv643xx_adjust_pscr().
> This commit renames the latter to the former, and therefore removes the extra
> and useless function.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
> ---
> drivers/net/ethernet/marvell/mv643xx_eth.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index b7b8d74..1e63c63 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -1010,8 +1010,10 @@ static void txq_set_fixed_prio_mode(struct tx_queue *txq)
>
>
> /* mii management interface *************************************************/
> -static void mv643xx_adjust_pscr(struct mv643xx_eth_private *mp)
> +static void mv643xx_eth_adjust_link(struct net_device *dev)
> {
> + struct mv643xx_eth_private *mp = netdev_priv(dev);
> +
> u32 pscr = rdlp(mp, PORT_SERIAL_CONTROL);
> u32 autoneg_disable = FORCE_LINK_PASS |
> DISABLE_AUTO_NEG_SPEED_GMII |
Please do not add empty lines in the middle of the function local variable declarations.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists