netdev - Re: [PATCH net] be2net: Poll for link status till 5s in ethtool diag test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 May 2014 16:14:19 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	ajit.khaparde@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: Poll for link status till 5s in ethtool
 diag test

From: Ajit Khaparde <ajit.khaparde@...lex.com>
Date: Mon, 5 May 2014 18:20:14 -0500

> After the loopback test is finished,
> it takes a few seconds for link to come back up.
> Poll for link status every 1 second interval for 5 seconds, only in cases
> when the link was UP before PHY loopback test was issued.
> 
> Signed-off-by: Suresh Reddy <suresh.reddy@...lex.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@...lex.com>

This is really anti-social, because the RTNL semaphore is held during
this entire call.

You are potentially blocking any and all network configuration setting
and fetches for up to 5 seconds.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html