netdev - Re: [PATCH net-next v3 1/2] net: systemport: only update UMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 May 2014 23:44:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/2] net: systemport: only update UMAC_CMD
 if something changed

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed,  7 May 2014 14:36:03 -0700

> Changes in v3:
> - make sure the second and third line after CMD_SPEED_MASK are aligned
>   properly
 ...
> +		reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) |
> +				CMD_HD_EN | CMD_RX_PAUSE_IGNORE |
> +				CMD_TX_PAUSE_IGNORE);

Still not right, in fact it looks like you didn't change anything
at all.

It should look like:

		reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) |
			 CMD_HD_EN | CMD_RX_PAUSE_IGNORE |
			 CMD_TX_PAUSE_IGNORE);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html