netdev - Re: [PATCH] jme: Fix DMA unmap warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 May 2014 09:04:29 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	netdev@...r.kernel.org, Guo-Fu Tseng <cooldavid@...ldavid.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] jme: Fix DMA unmap warning

On Sun, May 11, 2014 at 01:49:29PM +0100, Ben Hutchings wrote:
> On Mon, 2014-05-05 at 14:51 -0400, Neil Horman wrote:
> [...] 
> > -static void
> > +static void jme_drop_tx_map(struct jme_adapter *jme, int startidx, int endidx)
> > +{
> > +	struct jme_ring *txring = &(jme->txring[0]);
> > +	struct jme_buffer_info *txbi = txring->bufinf, *ctxbi;
> > +	int mask = jme->tx_ring_mask;
> > +	int j;
> > +
> > +	for (j = startidx ; j < endidx ; ++j) {
> > +		ctxbi = txbi + ((startidx + j + 2) & (mask));
> 
> So you're starting at startidx * 2 + 2, that can't be right.
> 
Shoot, I think j needs to be initalized to 0.

> [...]
> > @@ -2228,7 +2268,8 @@ jme_start_xmit(struct sk_buff *skb, struct net_device *netdev)
> >  		return NETDEV_TX_BUSY;
> >  	}
> >  
> > -	jme_fill_tx_desc(jme, skb, idx);
> > +	if (jme_fill_tx_desc(jme, skb, idx))
> > +		return NETDEV_TX_BUSY;
> 
> NETDEV_TX_OK
> 
Yup, I'll send a subsequent patch to fix it.  Thanks
Neil

> Ben.
> 
> >  	jwrite32(jme, JME_TXCS, jme->reg_txcs |
> >  				TXCS_SELECT_QUEUE0 |
> 
> -- 
> Ben Hutchings
> Sturgeon's Law: Ninety percent of everything is crap.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html