netdev - Re: [PATCH] net: phy: resume phydev when PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 12:46:05 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Jiancheng Xue <xuejiancheng@...wei.com>
Subject: Re: [PATCH] net: phy: resume phydev when PHY_RESUMING

2014-05-13 11:51 GMT-07:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> Hello.
>
>
> On 05/13/2014 01:23 PM, Zhangfei Gao wrote:
>
>> Commit be9dad1f9f26604fb suspend phydev when going to HALTED.
>
>
>    Please also specify that commit's summary line in parens.

That, and please rephrase your commit message such that we can
understand the problem this fixes. Something along the lines of:

"With commit be9dad1f9f26604fb ("net: phy: suspend phydev when going
to HALTED"), an unused PHY device will be put in a low-power mode
using BMCR_PDOWN. Some Ethernet drivers might be calling phy_connect()
and phy_disconnect() from their ndo_open, respectively ndo_close()
callbacks, in such a case, the PHY will be powered down during the
phy_disconnect() call, but will fail to be powered up in
phy_connect(). This patch fixes the following scenario."

Thanks

>
>
>> However not to resume phydev when going to RESUMING.
>> BMCR_PDOWN remains set "ifconfig eth0 down" -> "ifconfig eth0 up".
>> Unless phy_attach_direct is called in open function.
>
>
>> Fix the issue via phy_resume in PHY_RESUMING
>
>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@...wei.com>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>
>
>
> WBR, Sergei
>

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html