netdev - Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 18 May 2014 18:08:27 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
CC:	David Miller <davem@...emloft.net>,
	Roland Dreier <roland@...nel.org>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>, gxt@...c.pku.edu.cn,
	Matan Barak <matanb@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Shawn Bohrer <sbohrer@...advisors.com>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend
 on SMP

On 05/18/2014 03:55 AM, Or Gerlitz wrote:
> On Sat, May 17, 2014 at 8:36 AM, David Miller <davem@...emloft.net> wrote:
>>
>> From: Chen Gang <gang.chen.5i5j@...il.com>
>> Date: Sat, 17 May 2014 13:26:16 +0800
>>
>>> 'struct irq_affinity_notify' and the related functions are only defined
>>> when SMP enabled, so at present, mlx4 has to only run under SMP.
>>>
>>> The related error (allmodconfig under unicore32):
>>
>> Making the entire driver depend upon SMP is not the answer,
> 
> 
> Indeed, we would do that just for the relevant portion,
> 

Thank you for your work.

And next, when I meet the case like this again, instead of sending
patch, I shall send suggestion message to the related members/experts.


Thanks.
-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html