netdev - Re: [PATCH net] bridge: notify user space of fdb port change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 21:33:48 -0400 (EDT)
From:	Jon Maxwell <jmaxwell@...hat.com>
To:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc:	Jon Maxwell <jmaxwell37@...il.com>, stephen@...workplumber.org,
	davem@...emloft.net, vyasevic@...hat.com,
	bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, jpirko@...hat.com
Subject: Re: [PATCH net] bridge: notify user space of fdb port change


> I have no more comments except for style problems (bracket position,
> indentation, type mismatch).
> thank you for rewriting :)

np, yes this is a draft but I will make sure complies with checkpatch.pl
before submitting it.

Regards

Jon

> 
> Thanks,
> Toshiaki Makita
> 
> > 
> > $ diff -Naur br_fdb.c br_fdb.c.patch
> > --- br_fdb.c        2014-05-17 12:43:23.346319609 +1000
> > +++ br_fdb.c.patch        2014-05-17 16:54:46.280235728 +1000
> > @@ -487,6 +487,7 @@
> >  {
> >          struct hlist_head *head = &br->hash[br_mac_hash(addr, vid)];
> >          struct net_bridge_fdb_entry *fdb;
> > +        bool fdb_modified = 0;
> >  
> >          /* some users want to always flood. */
> >          if (hold_time(br) == 0)
> > @@ -507,10 +508,16 @@
> >                                          source->dev->name);
> >                  } else {
> >                          /* fastpath: update of existing entry */
> > -                        fdb->dst = source;
> > +                        if (unlikely(source != fdb->dst))
> > +                                {
> > +                                fdb->dst = source;
> > +                                fdb_modified = 1;
> > +                                }
> >                          fdb->updated = jiffies;
> >                          if (unlikely(added_by_user))
> >                                  fdb->added_by_user = 1;
> > +                        if (unlikely(fdb_modified))
> > +                                fdb_notify(br, fdb, RTM_NEWNEIGH);
> >                  }
> >          } else {
> >                  spin_lock(&br->hash_lock);
> > 
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html