netdev - Re: [PATCH 1/1] net: Set NOCARRIER bit of etherdev state at initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 May 2014 18:52:15 +0530
From:	Balakumaran Kannan <kumaran.4353@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	dcbw@...hat.com, stephen@...workplumber.org,
	Avinash Kumar <avi.kp.137@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] net: Set NOCARRIER bit of etherdev state at initialization

On Fri, May 23, 2014 at 11:45 PM, David Miller <davem@...emloft.net> wrote:
> From: Dan Williams <dcbw@...hat.com>
> Date: Fri, 23 May 2014 12:38:01 -0500
>
>> The current "carrier on until told otherwise" model is intentional,
>> because not all drivers support carrier detection, and thus we must
>> assume the carrier is on until the driver tells us it is not on.
>>
>> Would this patch break that model?
>
> Absolutely correct, this change is completely inappropriate.

So it is driver's responsibility to maintain this flag appropriately.
Thus if a driver supports carrier detection, it should set "carrier
on" only after determining the carrier state. Then I'll add
'netif_carrier_off' call to smsc911x driver and send a new patch.

Thanks for the explanation.

Regards,
K.Balakumaran
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html