netdev - Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 May 2014 11:29:58 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Vlad Yasevich <vyasevich@...il.com>, <kaber@...sh.net>,
	<davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address
 changes for passthru mode

On 2014/5/29 0:24, Vlad Yasevich wrote:
> On 05/26/2014 08:10 AM, Ding Tianhong wrote:
>> Ding Tianhong (2):
>>   macvlan: don't change macvlan address alone for passthru mode
>>   macvlan: propagate lowerdev mac address changes for passthru mode
>>
>>  drivers/net/macvlan.c | 40 +++++++++++++++++++++++++++++++---------
>>  1 file changed, 31 insertions(+), 9 deletions(-)
>>
> 
> This ends up working kind-of backwards...  A user now has to know
> that passthru macvlans he has to change the lower-level mac, but
> for all others, changing the macvlan mac is ok and will work...

Yes, more rules for it, but I think a user should know it.

> 
> This also will not work if the passthru macvlan is stacked on
> something other the hw (for example: a vlan).

passthru is a special mode, will not be used for every situation.

> 
> Why not simply propagate the mac address change of the passhtru macvlan
> down to the real device?
> 
Yes, I am considering this problem for a long time, I'm not sure the macvlan should propagate the mac address change to
the real device, but your suggestion looks good to me, thanks for your advise, I will think about it and fix it.

Ding

> Thanks
> -vlad
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html