netdev - Re: [PATCH] net: ks8851: Don't use regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2014 20:54:27 -0500
From:	Nishanth Menon <nm@...com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	"David S . Miller" <davem@...emloft.net>,
	linux-arm-msm@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>, netdev@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] net: ks8851: Don't use regulator_get_optional()

On Wed, May 28, 2014 at 3:11 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> We shouldn't be using regulator_get_optional() here. These
> regulators are always present as part of the physical design and
> there isn't any way to use an internal regulator or change the
> source of the reference voltage via software. Given that the only
> users of this driver in the kernel are DT based, this change
> should be transparent to them even if they don't specify any
> supplies because the regulator framework will insert dummy
> supplies as needed.
>
> Cc: Nishanth Menon <nm@...com>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---

Reviewed-and-Tested-by: Nishanth Menon <nm@...com>

SDP2430: with next-20140529:
before patch: https://github.com/nmenon/kernel-test-logs/blob/next-20140529/omap2plus_defconfig/sdp2430.txt

After patch: http://slexy.org/raw/s21sryFhAx
Looks good.
---
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html