netdev - Re: [PATCH v3] net/phy: tune get_phy_c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 May 2014 17:41:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Shengzhou.Liu@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] net/phy: tune get_phy_c45_ids to support more c45
 phy

From: Shengzhou Liu <Shengzhou.Liu@...escale.com>
Date: Wed, 28 May 2014 16:54:36 +0800

> -	/* Find first non-zero Devices In package.  Device
> -	 * zero is reserved, so don't probe it.
> -	 */
> +	/* Find first non-zero Devices In package */
>  	for (i = 1;
>  	     i < num_ids && c45_ids->devices_in_package == 0;
>  	     i++) {
 ...
> -			return 0;
> +			if (i) {

It makes no sense to test 'i' for zero vs. non-zero until the looping
construct it is contained within can actually hit a zero value.

It cannot currently, and adding such a check here makes the code
confusing.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html