netdev - Re: [PATCH net-next] net: ipconfig: allow IP-Config over DSA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jun 2014 11:02:31 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Lennert Buytenhek <buytenh@...tstofly.org>
Subject: Re: [PATCH net-next] net: ipconfig: allow IP-Config over DSA devices

2014-05-31 0:04 GMT-07:00 Jiri Pirko <jiri@...nulli.us>:
> Fri, May 30, 2014 at 08:08:45PM CEST, f.fainelli@...il.com wrote:
>>Hi David, Lennert, Jiri,
>>
>>This small patch allows us to use the kernel IP auto-configuration on DSA
>>enabled devices.
>>
>>I initially started implementing the netdev_upper_dev_link() calls for the
>>DSA slave devices, but ended up realizing that although this might be useful,
>>the other drivers or protocols implementing these master/slave relantionship
>>are the bonding driver and the VLAN code.
>>
>>None of these interfaces (bonding or VLAN) can be created by the kernel
>>without modifications, which means that user-space is there, and so we could
>>pivot_root over a NFS mounted share for instance, hence making the master/slave
>>net_device relationship not so useful for IP-Config.
>>
>>This is not the case with DSA devices which are solely created by the kernel
>>based on platform configuration.
>>
>>Let me know your thoughts. If you feel like something like:
>>netdev_is_upper_dev() or something like that is better.
>
> uppers and lowers should not be used by switches. If they were, it would
> block the usage of ports in bond/bridge/ovs. I did that myself in my
> first RFC patchset but realized that it make no sense.
>
> What I have in mind and I believe that many people nodded to is an
> exported (netlink, sysfs) value of switch id. That can be generated
> randomly or from some hw id. Please see following git tree:
>
> https://github.com/jpirko/net-next-rocker
>
> On the tip, there are rocker patches combined with the switch
> infrastructure patches. The switch id is there implemented for dsa and
> rocker.
>
> This is based on the RFC patchset I sent some while ago on netdev
> mailing list.
>
> Please tell me what do you think.

The way the switch_id attribute is implemented, is currently a
property of the slave aka per-port net_devices, which makes sense.
That does not entirely help me in my case, which is bringing up the
master/parent network device of these slave devices. We are still
missing a "generic" way to tell how a slave per-port network device
relates to its "conduit" network device.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html