netdev - Re: [PATCH] gianfar: Call netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jun 2014 16:04:49 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Claudiu Manoil <claudiu.manoil@...escale.com>,
	netdev <netdev@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration

2014-06-03 15:55 GMT-07:00 Fabio Estevam <festevam@...il.com>:
> From: Fabio Estevam <fabio.estevam@...escale.com>
>
> Quoting David Miller:
> "At the moment you call register_netdev() the device is visible, notifications
> are sent to userspace, and userland tools can try to bring the interface up
> and see the incorrect link state, before you do the netif_carrier_off().
>
> Said another way, between the register_netdev() and netif_carrier_off() call,
> userspace can see the device in an inconsistent state."
>
> So call netif_carrier_off() prior to register_netdev().

Potentially all drivers implementing libphy correctly should be fixed
to start with a carrier off until the phy library has determined
otherwise.

>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
> This is untested
>
>  drivers/net/ethernet/freescale/gianfar.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index a7fe6a7..861e0c9 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -1384,6 +1384,9 @@ static int gfar_probe(struct platform_device *ofdev)
>
>         gfar_hw_init(priv);
>
> +       /* Carrier starts down, phylib will bring it up */
> +       netif_carrier_off(dev);
> +
>         err = register_netdev(dev);
>
>         if (err) {
> @@ -1391,9 +1394,6 @@ static int gfar_probe(struct platform_device *ofdev)
>                 goto register_fail;
>         }
>
> -       /* Carrier starts down, phylib will bring it up */
> -       netif_carrier_off(dev);
> -
>         device_init_wakeup(&dev->dev,
>                            priv->device_flags &
>                            FSL_GIANFAR_DEV_HAS_MAGIC_PACKET);
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html