netdev - Re: [PATCH] gianfar: Call netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Jun 2014 19:42:04 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	festevam@...il.com, claudiu.manoil@...escale.com,
	netdev@...r.kernel.org, fabio.estevam@...escale.com
Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration

Le 03/06/2014 19:05, David Miller a écrit :
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Tue, 3 Jun 2014 16:04:49 -0700
>
>> 2014-06-03 15:55 GMT-07:00 Fabio Estevam <festevam@...il.com>:
>>> From: Fabio Estevam <fabio.estevam@...escale.com>
>>>
>>> Quoting David Miller:
>>> "At the moment you call register_netdev() the device is visible, notifications
>>> are sent to userspace, and userland tools can try to bring the interface up
>>> and see the incorrect link state, before you do the netif_carrier_off().
>>>
>>> Said another way, between the register_netdev() and netif_carrier_off() call,
>>> userspace can see the device in an inconsistent state."
>>>
>>> So call netif_carrier_off() prior to register_netdev().
>>
>> Potentially all drivers implementing libphy correctly should be fixed
>> to start with a carrier off until the phy library has determined
>> otherwise.
>
> Are you saying we should hold off on this gianfar patch?

Not at all, I think this patch is fine. If Fabio wants/can audit the 
other Freescale drivers I think this should be beneficial.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html