lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Jun 2014 10:26:22 +0200 From: Daniel Borkmann <dborkman@...hat.com> To: Alexei Starovoitov <alexei.starovoitov@...il.com> CC: Eric Dumazet <eric.dumazet@...il.com>, Cong Wang <xiyou.wangcong@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [Patch net-next] net: remove some useless list_del() On 06/04/2014 04:18 AM, Alexei Starovoitov wrote: > On Tue, Jun 3, 2014 at 5:43 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: >> On Tue, 2014-06-03 at 17:11 -0700, Cong Wang wrote: >>> "list_kill" is allocated on stack and it's a list head, >>> it is pointless to call list_del(&kill_list) especially >>> after unregister_netdevice_many(). >> >> How pointless exactly ? Explain more please. >> >> I suggest you read various commits adding these list_del() >> >> f87e6f47933e3ebeced9bb12615e830a72cedce4 is a good start. > > Interesting thread. Thanks guys! > detailed explanation by Linus: > https://lkml.org/lkml/2011/2/17/267 Indeed, thanks for the pointer. On that note, if you grep for unregister_netdevice_many() invocations, you'll see many more such cases that would need a list_del() actually. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists