netdev - Re: [patch net-next 2/2] net: use ethtool_cmd_speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 15:02:11 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>
Subject: Re: [patch net-next 2/2] net: use ethtool_cmd_speed_set helper to
 set ethtool speed value

Fri, Jun 06, 2014 at 02:24:49PM CEST, David.Laight@...LAB.COM wrote:
>From: Jiri Pirko
>...
>> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> @@ -141,6 +141,7 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>>  	struct e1000_dev_spec_82575 *dev_spec = &hw->dev_spec._82575;
>>  	struct e1000_sfp_flags *eth_flags = &dev_spec->eth_flags;
>>  	u32 status;
>> +	u32 speed;
>...
>> +		speed = SPEED_UNKNOWN;
>
>SPEED_UNKNOWN is defined as -1

Correct.

static inline void ethtool_cmd_speed_set(struct ethtool_cmd *ep, __u32 speed)

>
>	David
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html