netdev - Re: [PATCH] tcp: add gfp parameter to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 19:20:28 +0300
From:	Octavian Purdila <octavian.purdila@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Christoph Paasch <christoph.paasch@...ouvain.be>
Subject: Re: [PATCH] tcp: add gfp parameter to tcp_fragment

On Fri, Jun 6, 2014 at 6:52 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2014-06-06 at 17:32 +0300, Octavian Purdila wrote:
>> tcp_fragment can be called from process context (from tso_fragment).
>> Add a new gfp parameter to allow it to preserve atomic memory if
>> possible.
>>
>> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>
>> Reviewed-by: Christoph Paasch <christoph.paasch@...ouvain.be>
>> ---
>
> Seems fine to me.
>
> I am curious to know why you need this ?
>
> It seems real issue here might be different.
>
> Is it because of some performance issue ?
>

No, we noticed this while doing cleaning up the MPTCP code (where
tcp_fragment calls from process context are more frequent) , and we
thought it might be useful upstream as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html