lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 08 Jun 2014 22:48:00 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Gao feng <gaofeng@...fujitsu.com> Cc: Cong Wang <xiyou.wangcong@...il.com>, Linux Kernel Network Developers <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH net-next] net: force a list_del() in unregister_netdevice_many() On Mon, 2014-06-09 at 09:27 +0800, Gao feng wrote: > On 06/06/2014 09:44 PM, Eric Dumazet wrote: > > From: Eric Dumazet <edumazet@...gle.com> > > > > unregister_netdevice_many() API is error prone and we had too > > many bugs because of dangling LIST_HEAD on stacks. > > > > See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD") > > > > In fact, instead of making sure no caller leaves an active list_head, > > just force a list_del() in the callee. No one seems to need to access > > the list after unregister_netdevice_many() > > > > Just like the patch I posted one year ago, interesting :) > http://patchwork.ozlabs.org/patch/223521/ Yeah, apparently no caller has to keep around the list in current kernel. Not sure how it was last year. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists