lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Jun 2014 16:15:35 +0900 From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> To: Vlad Yasevich <vyasevich@...il.com>, "David S . Miller" <davem@...emloft.net>, Stephen Hemminger <stephen@...workplumber.org> CC: netdev@...r.kernel.org, bridge@...ts.linux-foundation.org Subject: Re: [PATCH net-next 4/4] bridge: Support 802.1ad vlan filtering (2014/06/10 9:50), Vlad Yasevich wrote: > On 06/09/2014 07:34 AM, Toshiaki Makita wrote: >> This enables us to change the vlan protocol for vlan filtering. >> We come to be able to filter frames on the basis of 802.1ad vlan tags >> through a bridge. >> >> This also changes br->group_addr if it has not been set by user. >> This is needed for an 802.1ad bridge. >> (See IEEE 802.1Q-2011 8.13.5.) >> >> To change the vlan protocol, write a protocol in sysfs: >> # echo 0x88a8 > /sys/class/net/br0/bridge/vlan_protocol >> >> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> >> --- >> net/bridge/br_private.h | 2 ++ >> net/bridge/br_sysfs_br.c | 18 +++++++++++ >> net/bridge/br_vlan.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 101 insertions(+) >> >> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h >> index 65204c2..3c5b23b 100644 >> --- a/net/bridge/br_private.h >> +++ b/net/bridge/br_private.h >> @@ -246,6 +246,7 @@ struct net_bridge >> unsigned long bridge_forward_delay; >> >> u8 group_addr[ETH_ALEN]; >> + unsigned char group_addr_set; > > nit: can be bool since you just use true/false. I'm not sure which is better in struct... but maybe it's more explicit. will change it in v2. Thanks, Toshiaki Makita -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists