lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jun 2014 13:45:27 +0300 From: Or Gerlitz <or.gerlitz@...il.com> To: David Miller <davem@...emloft.net>, Wei-Chun Chao <weichunc@...mgrid.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au> Subject: Re: [PATCH net] net: fix UDP tunnel GSO of frag_list GRO packets On Wed, Jun 11, 2014 at 10:49 AM, David Miller <davem@...emloft.net> wrote: > From: Wei-Chun Chao <weichunc@...mgrid.com> > Date: Sun, 8 Jun 2014 23:48:54 -0700 > >> This patch fixes a kernel BUG_ON in skb_segment. It is hit when >> testing two VMs on openvswitch with one VM acting as VXLAN gateway. >> >> During VXLAN packet GSO, skb_segment is called with skb->data >> pointing to inner TCP payload. skb_segment calls skb_network_protocol >> to retrieve the inner protocol. skb_network_protocol actually expects >> skb->data to point to MAC and it calls pskb_may_pull with ETH_HLEN. >> This ends up pulling in ETH_HLEN data from header tail. As a result, >> pskb_trim logic is skipped and BUG_ON is hit later. >> >> Move skb_push in front of skb_network_protocol so that skb->data >> lines up properly. > ... >> Signed-off-by: Wei-Chun Chao <weichunc@...mgrid.com> > > Applied, thank you. Hi Wei-Chun, So how long the bug exists? was it introduced 3.15-rc cycle or earlier? I guess it needs to go into -stable too, right? Or. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists