netdev - Re: [patch] amd-xgbe: unwind on error in xgbe_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 08:15:39 -0500
From:	Tom Lendacky <thomas.lendacky@....com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	<netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] amd-xgbe: unwind on error in xgbe_mdio_register()

On 06/11/2014 01:56 AM, Dan Carpenter wrote:
> There is a typo here so we return directly instead of unwinding.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 52bbdbf..ea7a5d6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
>
>   	if (!phydev->drv || (phydev->drv->phy_id == 0)) {
>   		netdev_err(netdev, "phy_id not valid\n");
> -		return -ENODEV;
> +		ret = -ENODEV;
>   		goto err_phy_connect;
>   	}
>   	DBGPR("  phy_connect_direct succeeded for PHY %s, link=%d\n",
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html