netdev - Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Jun 2014 19:26:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xerofoify@...il.com
Cc:	andriy.shevchenko@...ux.intel.com, dvhart@...ux.intel.com,
	jeffrey.t.kirsher@...el.com, ast@...mgrid.com, dborkman@...hat.com,
	bhutchings@...arflare.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Missing return check against Null for return value of
 netdev_alloc_dev_skb()

From: Nick Krause <xerofoify@...il.com>
Date: Sun, 15 Jun 2014 16:27:23 -0400

> From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001
> From: Nick <xerofoify@...il.com>
> Date: Sun, 15 Jun 2014 16:16:14 -0400
> Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers()
> Here is the fixed patch changed return type of function to int in
> order to use return -ENOMEM as with the function above it , seems to
> fit , otherwise returns 0.
>  Report if it breaks anything related to this driver.
> Signed-off-by: Nick <xerofoify@...il.com>

Nobody is checking the return value, you can't just change the function to
return an error code, you have to make the caller act upon it appropriately
as well.

I'm very much not confident that you are willing to put in the effort
necessary to fix this problem properly.

I told you explicitly that if this memory allocation failure occurs, the
bringup of the device has to fail.

Your patch is making the situation worse, it breaks when there is an
allocation failure, leaving the TX run partially allocated so that the
driver will crash with an OOPS later.

>From your first iteration, you aren't build testing this change, and I
therefore severely doubt you are functionally testing this change either.

I hate to be harsh, but this is an extremely _poor_ patch submission.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html