netdev - Re: [PATCH net 2/2] net: make some functions return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2014 15:32:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	panweiping3@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: make some functions return void

From: Weiping Pan <panweiping3@...il.com>
Date: Mon, 16 Jun 2014 21:57:23 +0800

> dev_close_many(), __dev_close_many() and __dev_close() do not need to return a
> int, so make them return void, and modify __dev_change_flags() accordingly.
> 
> Signed-off-by: Weiping Pan <panweiping3@...il.com>

I agree with other reviewers that this doesn't make much sense and it's
better to have the close functions have consistent return types.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html