netdev - Re: [PATCH v2] of: mdio: fixup of_phy_register_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 01:34:27 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Richard Retanubun <rretanubun.work@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH v2] of: mdio: fixup of_phy_register_fixed_link parsing
 of new bindings

Hello.

On 06/20/2014 01:28 AM, Richard Retanubun wrote:

> Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

> Fix the parsing of the new fixed link dts bindings for duplex,
> pause, and asym_pause by using the correct device node pointer.

> Signed-off-by: Richard Retanubun <rretanubun.work@...il.com>
> ---
> v2: Clean up code indentation. Thanks Sergei!

    Unfortunately, you've misunderstood me. :-/

>   drivers/of/of_mdio.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 7700ddc..b5f7817 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
>   	fixed_link_node = of_get_child_by_name(np, "fixed-link");
>   	if (fixed_link_node) {
>   		status.link = 1;
> -		status.duplex = of_property_read_bool(np, "full-duplex");
> +		status.duplex = of_property_read_bool(fixed_link_node,
> +							"full-duplex");

    When I said that continuation line should start under 'fixed_link_node', I 
meant it should start right under first letter of this name, after (. You 
don't need to use tabs only when indenting the networking code, appropriate 
number of spaces after tabs is OK.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html