lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jun 2014 11:57:51 +0530 (IST) From: Govindarajulu Varadarajan <_govind@....com> To: Joe Perches <joe@...ches.com> cc: linux-kernel@...r.kernel.org, Christian Benvenuti <benve@...co.com>, Sujith Sankar <ssujith@...co.com>, Govindarajulu Varadarajan <_govind@....com>, Neel Patel <neepatel@...co.com>, netdev@...r.kernel.org Subject: Re: [PATCH 10/22] enic: Use pci_zalloc_consistent On Mon, 23 Jun 2014, Joe Perches wrote: > Remove the now unnecessary memset too. > > Signed-off-by: Joe Perches <joe@...ches.com> Looks good, thanks Acked-by: Govindarajulu Varadarajan <_govind@....com> > --- > drivers/net/ethernet/cisco/enic/vnic_dev.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/cisco/enic/vnic_dev.c b/drivers/net/ethernet/cisco/enic/vnic_dev.c > index e86a45c..8a4799c 100644 > --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c > +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c > @@ -432,14 +432,12 @@ int vnic_dev_fw_info(struct vnic_dev *vdev, > int err = 0; > > if (!vdev->fw_info) { > - vdev->fw_info = pci_alloc_consistent(vdev->pdev, > - sizeof(struct vnic_devcmd_fw_info), > - &vdev->fw_info_pa); > + vdev->fw_info = pci_zalloc_consistent(vdev->pdev, > + sizeof(struct vnic_devcmd_fw_info), > + &vdev->fw_info_pa); > if (!vdev->fw_info) > return -ENOMEM; > > - memset(vdev->fw_info, 0, sizeof(struct vnic_devcmd_fw_info)); > - > a0 = vdev->fw_info_pa; > a1 = sizeof(struct vnic_devcmd_fw_info); > > -- > 1.8.1.2.459.gbcd45b4.dirty > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists