netdev - [PATCH] enic: fix a building failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2014 10:09:39 +0800
From:	roy.qing.li@...il.com
To:	netdev@...r.kernel.org
Cc:	jim.epost@...il.com, _govind@....com
Subject: [PATCH] enic: fix a building failure

From: Li RongQing <roy.qing.li@...il.com>

When RFS_ACCEL is disabled, the building failed:
    drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’:
    drivers/net/ethernet/cisco/enic/enic_main.c:1603:2: error: implicit declaration
    of function ‘enic_rfs_flw_tbl_init’ [-Werror=implicit-function-declaration]
      enic_rfs_flw_tbl_init(enic);
      ^
    drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_stop’:
    drivers/net/ethernet/cisco/enic/enic_main.c:1630:2: error: implicit declaration
    of function ‘enic_rfs_flw_tbl_free’ [-Werror=implicit-function-declaration]
      enic_rfs_flw_tbl_free(enic);

In fact, these two functions have been defined separately for enabling RFS_ACCEL
and disabling RFS_ACCEL.

Reported-by: Jim Davis <jim.epost@...il.com>
Cc: Govindarajulu Varadarajan <_govind@....com>
Signed-off-by: Li RongQing <roy.qing.li@...il.com>
---
 drivers/net/ethernet/cisco/enic/enic_clsf.h |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_clsf.h b/drivers/net/ethernet/cisco/enic/enic_clsf.h
index 76a85bb..b38cc7e 100644
--- a/drivers/net/ethernet/cisco/enic/enic_clsf.h
+++ b/drivers/net/ethernet/cisco/enic/enic_clsf.h
@@ -9,11 +9,8 @@
 int enic_addfltr_5t(struct enic *enic, struct flow_keys *keys, u16 rq);
 int enic_delfltr(struct enic *enic, u16 filter_id);
 
-#ifdef CONFIG_RFS_ACCEL
 void enic_rfs_flw_tbl_init(struct enic *enic);
 void enic_rfs_flw_tbl_free(struct enic *enic);
 int enic_rx_flow_steer(struct net_device *dev, const struct sk_buff *skb,
 		       u16 rxq_index, u32 flow_id);
-#endif /* CONFIG_RFS_ACCEL */
-
 #endif /* _ENIC_CLSF_H_ */
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html