netdev - Re: [PATCH] enic: fix a building failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2014 19:21:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, jim.epost@...il.com, _govind@....com
Subject: Re: [PATCH] enic: fix a building failure

From: roy.qing.li@...il.com
Date: Fri, 27 Jun 2014 10:09:39 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> When RFS_ACCEL is disabled, the building failed:
>     drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’:
>     drivers/net/ethernet/cisco/enic/enic_main.c:1603:2: error: implicit declaration
>     of function ‘enic_rfs_flw_tbl_init’ [-Werror=implicit-function-declaration]
>       enic_rfs_flw_tbl_init(enic);
>       ^
>     drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_stop’:
>     drivers/net/ethernet/cisco/enic/enic_main.c:1630:2: error: implicit declaration
>     of function ‘enic_rfs_flw_tbl_free’ [-Werror=implicit-function-declaration]
>       enic_rfs_flw_tbl_free(enic);
> 
> In fact, these two functions have been defined separately for enabling RFS_ACCEL
> and disabling RFS_ACCEL.
> 
> Reported-by: Jim Davis <jim.epost@...il.com>
> Cc: Govindarajulu Varadarajan <_govind@....com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Please pay attention, there is already a better fix checked into the
net-next tree.

The tree would still fail with your version of the fix, did you test
with RFS_ACCEL disabled?  You have to provide an actual implementation
when RFC_ACCEL is off, via an empty inline function in enic_clsf.h which is
what was done in net-next already.