netdev - Re: [PATCH net v3 2/3] libphy: Add stubs to hook IEEE MMD Register reads and writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 Jun 2014 14:47:04 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net v3 2/3] libphy: Add stubs to hook IEEE MMD Register
 reads and writes

On Mon, Jun 23, 2014 at 7:29 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 06/23/2014 04:21 AM, Vince Bridgers wrote:
>
>> The Micrel ksz9021 PHY does not support standard IEEE standard MMD
>> extended register access, therefore requires stubs to fail the read
>> register method and do nothing for the write register method when
>> libphy attempts to read and/or configure Energy Efficient Ethernet
>> features in PHYS that do support those features. This problem
>> was observed on an Altera Cyclone V SOC development kit that
>> uses the Synopsys EMAC and the Micrel ksz9021 PHY. This patch
>> was tested on the same board, and Energy Efficient Ethernet is
>> now disabled as expected since the Micrel PHY does not support that
>> feature.
>
>
>> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
>> ---
>> V3: Remove unnecessary returns from void functions.
>> V2: Split libphy and Micrel specific changes into 2 patches
>>      based on review comments
>> ---
>>   drivers/net/phy/micrel.c |   23 ++++++++++++++++++++++-
>>   1 file changed, 22 insertions(+), 1 deletion(-)
>
>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>> index bc7c7d2..daf8bab 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -417,7 +417,26 @@ static int ksz8873mll_read_status(struct phy_device
>> *phydev)
>>
>>   static int ksz8873mll_config_aneg(struct phy_device *phydev)
>>   {
>> -       return 0;
>
>
>    Eh? The function returns *int* and you're removing the only *return*
> statement?

Oops, thanks for catching this. I'll address and respin.

>
>> +}
>
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html