lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Jul 2014 20:05:34 -0700 From: Joe Perches <joe@...ches.com> To: "Maciej W. Rozycki" <macro@...ux-mips.org> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH v2] declance: Fix 64-bit compilation warnings On Thu, 2014-07-03 at 03:34 +0100, Maciej W. Rozycki wrote: > On Thu, 3 Jul 2014, Maciej W. Rozycki wrote: > > > > > @@ -499,8 +499,9 @@ static void lance_init_ring(struct net_d > > > > /* The ones required by tmd2 */ > > > > *lib_ptr(ib, btx_ring[i].misc, lp->type) = 0; > > > > if (i < 3 && ZERO) > > > > - printk("%d: 0x%8.8x(0x%8.8x)\n", > > > > - i, leptr, (uint)lp->tx_buf_ptr_cpu[i]); > > > > + printk("%d: 0x%8.8x(%#0*lx)\n", > > > > + i, leptr, 2 * (int)sizeof(long) + 2, > > > > + (long)lp->tx_buf_ptr_cpu[i]); > > > > > > Please just use "%p", no casts required. > > > > Hmm, there was something about %p that made me reject it, however I can't > > recall what it was and I can get the desired output with this format > > specifier (the NULL special case difference can be ignored, the pointers > > printed here won't ever be NULL). Sending an update right away. > > Ah, there it is: > > drivers/net/ethernet/amd/declance.c: In function 'lance_init_ring': > drivers/net/ethernet/amd/declance.c:503: warning: '#' flag used with '%p' printf format > drivers/net/ethernet/amd/declance.c:520: warning: '#' flag used with '%p' printf format > > That's obviously GCC's incompatibility to our implementation. I'm not > sure if that can be worked around, but I'll see what I can do about it. The kernel vsprintf implementation doesn't prefix pointers with 0x, so you can use 0x%p if you really want that with a leading prefix, but you don't have to use it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists