netdev - Re: [PATCH] defxx: Fix issues with debug printk calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 Jul 2014 09:44:00 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] defxx: Fix issues with debug printk calls

On Sat, 2014-07-05 at 15:28 +0100, Maciej W. Rozycki wrote:
[]
> +++ linux-20140623-swarm64-eb/drivers/net/fddi/defxx.h
> @@ -1693,7 +1693,7 @@ typedef union
>  /* Only execute special print call when debug driver was built */
>  
>  #ifdef DEFXX_DEBUG
> -#define DBG_printk(args...) printk(## args)
> +#define DBG_printk(args...) printk(args)
>  #else
>  #define DBG_printk(args...)
>  #endif

It'd be nicer to change this bit to

#ifdef DEFXX_DEBUG
#define DBG_printk(fmt, ...)					\
	printk(KERN_DEBUG fmt, ##__VA_ARGS__)
#else
#define DBG_printk(fmt, ...) 					\
	do (if (0) printk(KERN_DEBUG fmt, ##__VA_ARGS__); } while (0)
#endif

or just use pr_debug everywhere instead.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html