netdev - Re: [PATCH net-next 8/8] ethernet: amd: switch case fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 09:47:09 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	varkabhadram@...il.com
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Thomas.Lendacky@....com,
	Geert Uytterhoeven <geert+renesas@...ux-m68k.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net-next 8/8] ethernet: amd: switch case fixes

On Fri, Jul 11, 2014 at 9:35 AM,  <varkabhadram@...il.com> wrote:
> --- a/drivers/net/ethernet/amd/amd8111e.c
> +++ b/drivers/net/ethernet/amd/amd8111e.c
> @@ -197,23 +197,24 @@ static void amd8111e_set_ext_phy(struct net_device *dev)
>         advert = amd8111e_mdio_read(dev, lp->ext_phy_addr, MII_ADVERTISE);
>         tmp = advert & ~(ADVERTISE_ALL | ADVERTISE_100BASE4);
>         switch (lp->ext_phy_option) {
> -               default:

Behavior change from fall through and consider as auto-negotation...

> -               case SPEED_AUTONEG: /* advertise all values */
> -                       tmp |= (ADVERTISE_10HALF | ADVERTISE_10FULL |
> -                               ADVERTISE_100HALF | ADVERTISE_100FULL);
> -                       break;
> -               case SPEED10_HALF:
> -                       tmp |= ADVERTISE_10HALF;
> -                       break;
> -               case SPEED10_FULL:
> -                       tmp |= ADVERTISE_10FULL;
> -                       break;
> -               case SPEED100_HALF:
> -                       tmp |= ADVERTISE_100HALF;
> -                       break;
> -               case SPEED100_FULL:
> -                       tmp |= ADVERTISE_100FULL;
> -                       break;
> +       case SPEED_AUTONEG: /* advertise all values */
> +               tmp |= (ADVERTISE_10HALF | ADVERTISE_10FULL |
> +                       ADVERTISE_100HALF | ADVERTISE_100FULL);
> +               break;
> +       case SPEED10_HALF:
> +               tmp |= ADVERTISE_10HALF;
> +               break;
> +       case SPEED10_FULL:
> +               tmp |= ADVERTISE_10FULL;
> +               break;
> +       case SPEED100_HALF:
> +               tmp |= ADVERTISE_100HALF;
> +               break;
> +       case SPEED100_FULL:
> +               tmp |= ADVERTISE_100FULL;
> +               break;
> +       default:

... to do nothing.

> +               break;
>         }

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html