lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Jul 2014 21:37:47 -0300 From: Fabio Estevam <festevam@...il.com> To: David Miller <davem@...emloft.net>, Claudiu Manoil <claudiu.manoil@...escale.com> Cc: Stephen Hemminger <stephen@...workplumber.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, sebastian.poehn@...den.com Subject: Re: [Bug 79821] New: ethernet/freescale/gianfar_ethtool.c:1584: possible bad expression ? On Thu, Jul 10, 2014 at 9:07 PM, David Miller <davem@...emloft.net> wrote: > From: David Miller <davem@...emloft.net> > Date: Thu, 10 Jul 2014 17:06:10 -0700 (PDT) > >> From: Stephen Hemminger <stephen@...workplumber.org> >> Date: Thu, 10 Jul 2014 05:51:00 -0700 >> >>> [linux-3.16-rc4/drivers/net/ethernet/freescale/gianfar_ethtool.c:1584]: (style) >>> Same expression on both sides of '|'. >>> >>> for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl); >> >> Probably this is meant to be: >> >> diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c >> index 76d7070..f697118 100644 >> --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c >> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c >> @@ -1581,7 +1581,7 @@ static int gfar_write_filer_table(struct gfar_private *priv, >> return -EBUSY; >> >> /* Fill regular entries */ >> - for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl); >> + for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].prop); >> i++) >> gfar_write_filer(priv, i, tab->fe[i].ctrl, tab->fe[i].prop); >> /* Fill the rest with fall-troughs */ >> >> But only a Gianfar expert can say for sure. >> >> Sebastian, this is your code, please help us out. > > Ok, we have a problem, Sebastian's email bounces. > > Anyone else who knows this chip can help us out? We don't have a listed > maintainer for Gianfar in MAINTAINERS :-/ Adding Claudiu on Cc in case he could help. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists