netdev - Re: [PATCH net-next 0/3] bonding: rcu cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 12:55:19 +0200
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH net-next 0/3] bonding: rcu cleanups

On 07/15/2014 11:46 AM, Eric Dumazet wrote:
> RCU was added to bonding in linux-3.12 but lacked proper sparse annotations.
> 
> Using __rcu annotation actually helps to spot all accesses to bond->curr_active_slave
> are correctly protected, with full sparse & LOCKDEP support.
> 
> Lets clean the code.
> 
> Eric Dumazet (3):
>   bonding: get rid of bond_option_active_slave_get()
>   bonding: use rcu_access_pointer() in bonding_show_mii_status()
>   bonding: add proper __rcu annotation for curr_active_slave
> 
>  drivers/net/bonding/bond_alb.c     | 47 +++++++++++++++++++--------------
>  drivers/net/bonding/bond_main.c    | 53 +++++++++++++++++++++-----------------
>  drivers/net/bonding/bond_netlink.c | 21 +++++++++++----
>  drivers/net/bonding/bond_options.c |  7 +----
>  drivers/net/bonding/bond_sysfs.c   |  3 ++-
>  drivers/net/bonding/bonding.h      |  7 +++--
>  6 files changed, 81 insertions(+), 57 deletions(-)
> 
Nice clean up, I also gave it a quick run. I believe similar clean up would
be beneficial for current_arp_slave at some point.

Anyhow, thanks Eric!

For the set
Reviewed-by: Nikolay Aleksandrov <nikolay@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html